From 113b40f3aa5720a024144122546c7286e7cad1c0 Mon Sep 17 00:00:00 2001 From: Dave MacLachlan Date: Thu, 27 May 2021 10:02:08 -0700 Subject: [PATCH] All subclasses of OCMockObject should get `stopMocking` called on them as part of dealloc. This seems like a reasonable expectation of the API and in our case enables code that depends on stopMocking to function with OCProtocolMockObjects. --- Source/OCMock/OCClassMockObject.m | 6 ------ Source/OCMock/OCMockObject.m | 2 +- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/Source/OCMock/OCClassMockObject.m b/Source/OCMock/OCClassMockObject.m index b7cbb71f..b756c229 100644 --- a/Source/OCMock/OCClassMockObject.m +++ b/Source/OCMock/OCClassMockObject.m @@ -39,12 +39,6 @@ - (id)initWithClass:(Class)aClass return self; } -- (void)dealloc -{ - [self stopMocking]; - [super dealloc]; -} - - (NSString *)description { return [NSString stringWithFormat:@"OCClassMockObject(%@)", NSStringFromClass(mockedClass)]; diff --git a/Source/OCMock/OCMockObject.m b/Source/OCMock/OCMockObject.m index ec652b5d..7e92b0df 100644 --- a/Source/OCMock/OCMockObject.m +++ b/Source/OCMock/OCMockObject.m @@ -117,10 +117,10 @@ - (instancetype)init - (void)dealloc { + [self stopMocking]; [stubs release]; [expectations release]; [exceptions release]; - [invocations release]; [super dealloc]; }