Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With Build before ReAttaching enabled if the build fails don't attach to process. #27

Open
cyclr-adrian opened this issue May 4, 2022 · 2 comments · May be fixed by #28
Open

With Build before ReAttaching enabled if the build fails don't attach to process. #27

cyclr-adrian opened this issue May 4, 2022 · 2 comments · May be fixed by #28

Comments

@cyclr-adrian
Copy link

I'm using VS 2022 (Version 17.1.6) and have installed the ReAttach VSIX extension and have enabled the option Build before ReAttaching.

When I ReAttach using the extension my solution builds and then re-attaches to the last process which is what I expected it to do.

However if I make a change which stops the solution from successfully compiling the ReAttach extension runs the build as before but the build correctly fails but the ReAttach to the process still happens. I would have expected on a failed build that the ReAttach to process would not occur, highlighting an issue.

@erlandranvinge
Copy link
Owner

I totally agree. Apparently, that scenario was never tested. In fact, when looking at the code, the result of the actual build is not taken into account at all.

@erlandranvinge
Copy link
Owner

It seems like the automation object used to trigger build doesn't return anything. I guess one would need to implement something a bit more sophisticated in order to address this. E.g. IVsSolutionBuildManager might hold the key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants