Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UPD+FIX] Atualizando as bibliotecas do Pre-commit e corrigido conflito entre validações #46

Merged
merged 4 commits into from
Dec 10, 2024

Conversation

mbcosta
Copy link
Contributor

@mbcosta mbcosta commented Jan 22, 2024

Ao verificar o problema dos PRs #44 e #45 acabei rodando o comando do pre-commit localmente para manter o padrão do código, acabei vendo que estava retornando um erro E203 e procurei atualizar as bibliotecas para ver se resolvia, mas na verdade existe um conflito entre as bibliotecas Black e Flake8

https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#slices

This behaviour may raise E203 whitespace before ':' warnings in style guide enforcement tools like Flake8. Since E203 is not PEP 8 compliant, you should tell Flake8 to ignore these warnings.

https://www.flake8rules.com/rules/E203.html

https://flake8.pycqa.org/en/3.1.1/user/ignoring-errors.html

Então nesse PR estou atualizando as Libs, corrigindo esse conflito e ao rodar o comando pre-commit acaba refatorando algumas partes do código, com isso o pre-commit passou a rodar sem erros pelo menos localmente, é preciso verificar se vai precisar mais alterações aqui no github.

cc @renatonlima @rvalyi @marcelsavegnago @mileo

@mbcosta mbcosta force-pushed the UPD_FIX-pre_commit_libs branch 2 times, most recently from 494603f to c783041 Compare January 22, 2024 23:16
@mbcosta mbcosta force-pushed the UPD_FIX-pre_commit_libs branch from c783041 to 59ffa9c Compare January 22, 2024 23:24
@mbcosta
Copy link
Contributor Author

mbcosta commented Jan 22, 2024

Incluído um commit sobre o erro

https://github.com/erpbrasil/erpbrasil.base/actions/runs/7618270413/job/20749074292?pr=46#step:5:149
( readme: line 3) broken https://api.travis-ci.org/erpbrasil/erpbrasil.base.svg?branch=master - 404 Client Error: NOT FOUND for url: https://api.travis-ci.org/erpbrasil/erpbrasil.base.svg?branch=master
build finished with problems, 1 warning.

Pela mensagem a Imagem não foi encontrada, deveria ou faltou ser incluída?

@antoniospneto
Copy link

antoniospneto commented Jan 23, 2024

Incluído um commit sobre o erro

https://github.com/erpbrasil/erpbrasil.base/actions/runs/7618270413/job/20749074292?pr=46#step:5:149 ( readme: line 3) broken https://api.travis-ci.org/erpbrasil/erpbrasil.base.svg?branch=master - 404 Client Error: NOT FOUND for url: https://api.travis-ci.org/erpbrasil/erpbrasil.base.svg?branch=master build finished with problems, 1 warning.

Pela mensagem a Imagem não foi encontrada, deveria ou faltou ser incluída?

acho que o certo é remover mesmo, o travis não é mais utilizado aqui

@mileo mileo merged commit 3bd9d0c into erpbrasil:master Dec 10, 2024
24 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants