Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint config different from original #199

Open
JSlain opened this issue Sep 2, 2016 · 0 comments
Open

Eslint config different from original #199

JSlain opened this issue Sep 2, 2016 · 0 comments

Comments

@JSlain
Copy link

JSlain commented Sep 2, 2016

I have 2 gulp tasks:

  • running ESLint directly, making my build to fail if any error is discovered
  • running it in Plato to see the result in a friendly UI

I'm also using eslint-plugin-angular to have additional rules.

Here's my problem.
Plato uses a fixed version of ESLint, which is currently 3.0.1
In my project, i use the latest release which 3.4.0 (at the time i'm writing).

The angular plugin injects its rules in the current eslint, which is the 3.4.0 one.

So i have this:

|
+- [email protected]
|
+- eslint-plugin-angular
|
+- plato
   |
   +- [email protected]

Both of my tasks uses the same eslint config file, but only the root one (3.4.0) knows about angular rules.
When running plato analysis, there's a bunch of errors about unknown rules...

The workaround is to use the exact same version in my project, and remove/reinstall plato afterward. It'll find its dependency in my project and won't download it again on its own.

The solution is simple

I think plato should really depends on:
"eslint":"^3.0.0"
I don't see any reasons plato should depend on a fixed version. The fixed major version should be fine.

JSlain added a commit to JSlain/plato that referenced this issue Sep 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant