Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove is-builtin-module from sanity-io #47

Closed
43081j opened this issue May 6, 2024 · 2 comments
Closed

Remove is-builtin-module from sanity-io #47

43081j opened this issue May 6, 2024 · 2 comments

Comments

@43081j
Copy link
Collaborator

43081j commented May 6, 2024

Sanity's CLI has an engine constraint of >=18.

Node has had a built in isBuiltinModule function long before then, so we could drop the dependency
@43081j
Copy link
Collaborator Author

43081j commented May 6, 2024

Opened sanity-io/sanity#6579

@rexxars
Copy link

rexxars commented Dec 11, 2024

Merged, thank you for contributing!

@Fuzzyma Fuzzyma closed this as completed Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rexxars @Fuzzyma @43081j