Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more convenient path objects #371

Open
julianhoever opened this issue Aug 13, 2024 · 1 comment
Open

Use more convenient path objects #371

julianhoever opened this issue Aug 13, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@julianhoever
Copy link
Contributor

Currently, the ElasticAI.Creator uses custom path objects (InProjectPath, OnDiscPath, ...), which are not very intuitive and easy to use based on user experience. Therefore, we should replace these custom path objects with a more standardized path structure (e.g. pathlib.Path) if possible. This should make the ElasticAI.Creator more understandable.

@julianhoever julianhoever added the enhancement New feature or request label Aug 13, 2024
@glencoe
Copy link
Contributor

glencoe commented Aug 13, 2024

Tbh... i'd like to go even a step further and use something like a registry for architectures/entities. Each architecture/entity specifies a default name and before we produce code or in the moment an architecture/entity gets registered, we automatically generate the correct name (to avoid collisions). Then independently from that we can let an algorithm run over that registry and generate file paths and write the content there.

This way, developers would not have to worry about name collisions and we'd be in control about where/how resulting files will be stored.

@julianhoever julianhoever self-assigned this Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants