Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postbacks blocking code if postback server times out #6

Open
zoton2 opened this issue Feb 4, 2018 · 3 comments
Open

Postbacks blocking code if postback server times out #6

zoton2 opened this issue Feb 4, 2018 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@zoton2
Copy link
Member

zoton2 commented Feb 4, 2018

If there are any postback URLs set in the settings, and the server they are pointing at doesn't respond in 5 seconds, the server returns a 500(?) error and the rest of the code seems to be ignored.

The code does have that timeout parameter (opener.open(req, timeout=5)), the timeout should just fail gracefully, or we should change to using something that is async so it doesn't actually block the code if it's waiting.

@zoton2
Copy link
Member Author

zoton2 commented Feb 4, 2018

And now I post that, it seems to be a different matter. If the postback server doesn't exist (so I assume a 404) it will be fine, but if the postback server does exist but it doesn't return anything, it will block the code.

@zoton2
Copy link
Member Author

zoton2 commented Feb 6, 2018

No, from some more testing, it seems like it does happen if the server doesn't exist too.

@zephyyrr
Copy link
Member

zephyyrr commented Feb 7, 2018

I guess you just have to make sure the server is always there... listening...

@zephyyrr zephyyrr added this to the ESA Summer 2018 milestone Feb 13, 2018
@zephyyrr zephyyrr added enhancement New feature or request help wanted Extra attention is needed labels Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants