Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the check and dummy-deployment workflow to use the new reusable workflow with optional deployment #55

Merged
merged 4 commits into from
Jun 6, 2024

Conversation

JaroCamphuijsen
Copy link
Collaborator

This PR closes #54

@JaroCamphuijsen
Copy link
Collaborator Author

@raar1 this seems to work now. Can you confirm this is how you intended to use the deploy workflow?

Copy link
Collaborator

@raar1 raar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! But we don't need deployment on PRs to main

Copy link
Collaborator

@raar1 raar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@JaroCamphuijsen JaroCamphuijsen merged commit 983602b into main Jun 6, 2024
1 check passed
@JaroCamphuijsen JaroCamphuijsen deleted the update-workflow branch June 6, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change workflow to adhere to optional deployment
2 participants