Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: disallow merge pr labelled evaluating #69

Open
aladdin-add opened this issue Apr 28, 2018 · 1 comment
Open

proposal: disallow merge pr labelled evaluating #69

aladdin-add opened this issue Apr 28, 2018 · 1 comment

Comments

@aladdin-add
Copy link
Member

aladdin-add commented Apr 28, 2018

A PR would likely be merged by accident, when it has not been accepted, while someone have approved.
We can add checking evaluating label to wip plugin(though it's not really wip). or another plugin?

@platinumazure
Copy link
Member

Agreed in principle. I think we could either add it to wip (though maybe with a different status check text?), or create a new plugin. Creating a new plugin might not be a bad idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants