-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New rule: Normalize string keys #32
Comments
Ah interesting. I agree this would be good to catch. I'm wondering if this should be part of |
@nzakas I think duplicate keys via a config would be sane but the name of that role is a bit awkward since this occurs without having more than 1 key. |
Fair point. A new rule it is! Maybe |
bmeck
added a commit
to bmeck/eslint-json
that referenced
this issue
Oct 7, 2024
nzakas
pushed a commit
that referenced
this issue
Nov 20, 2024
nzakas
pushed a commit
that referenced
this issue
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Rule details
Normalize string keys
What type of rule is this?
Suggests an alternate way of doing something
Example code
Per https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/normalize , there are examples of unicode that are similar in character. Generally this could mean that there is a key mismatch on 2 apparently similar strings. Suggesting using a normalized form to avoid this potential issue would be good so that the following 2 object don't have mismatched keys:
There are valid use cases for these key mismatches, but they are generally very specific in scope.
Participation
Additional comments
Similar mismatches or deception such as using Bidi mixing / zero width characters etc. are potentially in the same vein but likely would be a different scope since those have associated CVEs.
The text was updated successfully, but these errors were encountered: