Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drupal/facets:2.0.5 has JS errors #224

Closed
DiegoPino opened this issue Nov 11, 2022 · 1 comment
Closed

drupal/facets:2.0.5 has JS errors #224

DiegoPino opened this issue Nov 11, 2022 · 1 comment
Assignees
@aksm
Labels
bug Something isn't working Check Reproducibility Basically if we can make things fail in the same way the user did Composer.json Keep your Libraries fresh
Milestone
1.1.0

Comments

@DiegoPino
Copy link
Member

See esmero/archipelago-deployment-live#93

This needs to be tested and patches soon. Should be for 1.0.0 and 1.1.0 (except if your composer.lock is already fetching 2.0.5)
@DiegoPino DiegoPino added bug Something isn't working Composer.json Keep your Libraries fresh Check Reproducibility Basically if we can make things fail in the same way the user did labels Nov 11, 2022
@DiegoPino DiegoPino added this to the 1.1.0 milestone Nov 11, 2022
@aksm
Copy link
Contributor

aksm commented Mar 29, 2023

Closing because this has been fixed for 2.0.5 stable since this issue was opened:

https://git.drupalcode.org/project/facets/-/blob/2.0.5/modules/facets_range_widget/js/slider.js#L6

@aksm aksm closed this as completed Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aksm aksm

Labels
bug Something isn't working Check Reproducibility Basically if we can make things fail in the same way the user did Composer.json Keep your Libraries fresh
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
2 participants
@DiegoPino @aksm