Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-127 and ISSUE-128: adds snac + better draft session management when editing/cloning #129

Merged
merged 6 commits into from
Aug 23, 2021

Conversation

DiegoPino
Copy link
Member

@DiegoPino DiegoPino commented Aug 3, 2021

What?

See #127 and #128

  • Adds new webform element for SNAC https://snaccooperative.org
  • Deeply reforms Draft Saving. On Object Edit open Drafts are untouched. On cloning (and any Code base Entity Duplication) Drafts are not used so you do not end with legacy data.
  • "you have an unfinished" session message now is part of the Widget Title (to avoid aggressive themes to try to show that as a message on every Form/webform submit (even hidden operations like changing the Type of Agent triggered this on the Bootstrap Barrio theme)

This basically discerns if an edit session can use Drafts (e.g Cloning can not) and we keep Draft sessions separated from normal advance sessions. Reason for that is we need to be able to Edit a Node without touching an ongoing/Draft session too.

We use the same widget ID as temporary private store storage but we add a -draft

Also:
- Marks Draft as Saved (message( with normal Operations (next/previous buttons) by setting  $form_state->set('draft_saved', TRUE); Those buttons still validate the form v/s the Top navigation one.
- Add the Step number in the message when reaching the last step and validation for previous ones fails
…controllers

without validation/user session readable
@DiegoPino DiegoPino added enhancement New feature or request Webform Widgets Connecting Webforms and Entity Fields UI/UX The thing people do when in front of a screen Webform Elements Things with input to fill and interact with while ingesting metadata Webform Handler External API Things we do not control but we depend on labels Aug 3, 2021
@DiegoPino DiegoPino requested a review from alliomeria August 3, 2021 20:18
@DiegoPino DiegoPino self-assigned this Aug 3, 2021
@DiegoPino
Copy link
Member Author

@alliomeria added an issue here for corporateBody
snac-cooperative/snac#298

DiegoPino and others added 3 commits August 17, 2021 12:50
Removed pair because it requires two entries. A top level descriptor and a sub heading match.

A.g Descriptor: Virus Attachment qualifier: drug effects leads to this Descriptor
Virus Attachment/drug effects

IMPORTANT: autocomplete after the first entry works on full words.

e.g

Virus or Virus Attachment but not on Virus A
@DiegoPino DiegoPino merged commit 2d498fe into 1.0.0-RC3 Aug 23, 2021
@DiegoPino DiegoPino deleted the ISSUE-124 branch August 23, 2021 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request External API Things we do not control but we depend on UI/UX The thing people do when in front of a screen Webform Elements Things with input to fill and interact with while ingesting metadata Webform Handler Webform Widgets Connecting Webforms and Entity Fields
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant