Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deku to 0.17.0 #37

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Update deku to 0.17.0 #37

merged 2 commits into from
Jun 6, 2024

Conversation

wcampbell0x2a
Copy link
Contributor

@jessebraham
Copy link
Member

Thanks for the PR. I guess we will need to bump the MSRV to 1.71.0 to get CI green, if you wouldn't mind making those changes.

@wcampbell0x2a
Copy link
Contributor Author

Thanks for the PR. I guess we will need to bump the MSRV to 1.71.0 to get CI green, if you wouldn't mind making those changes.

Sure, pushed updates to do that.

@MabezDev
Copy link
Member

MabezDev commented Jun 5, 2024

@wcampbell0x2a You also need to bump the MSRV inside the CI workflow to get it passing :)

@wcampbell0x2a
Copy link
Contributor Author

@wcampbell0x2a You also need to bump the MSRV inside the CI workflow to get it passing :)

done

jessebraham
jessebraham approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jessebraham jessebraham merged commit d2cf29a into esp-rs:main Jun 6, 2024
5 checks passed
@wcampbell0x2a wcampbell0x2a deleted the update-deku-0.17.0 branch November 6, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessebraham jessebraham jessebraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wcampbell0x2a @jessebraham @MabezDev