Re-export Rsa since it is a parameter of Session::new() #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a quality of life improvement, as it allows a library to wrap esp-mbedtls without having to re-import the hal for the Rsa struct.
AnthonyGrondin
added a commit
to AnthonyGrondin/esp-mbedtls
that referenced
this pull request
Jul 10, 2024
This revert the change made in esp-rs#27 now that Session no longer thake an instance of the driver.
AnthonyGrondin
added a commit
to AnthonyGrondin/esp-mbedtls
that referenced
this pull request
Jul 10, 2024
This revert the change made in esp-rs#27 now that Session no longer take an instance of the driver.
bjoernQ
pushed a commit
that referenced
this pull request
Jul 15, 2024
* Update to esp-hal 0.18.0 * chore: Remove pub export of Rsa that is no longer needed This revert the change made in #27 now that Session no longer take an instance of the driver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quality of life improvement, as it allows a library to wrap esp-mbedtls without having to re-import the hal for the Rsa struct.