fix compat with Plone 4.3.8+ #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4.3.8 bumped the pinned version of requests to 2.9.1 (and 4.3.10 has 2.10.0), conflicting with the "requests >= 0.9, < 1.0" pin here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plone 4.3.8 bumped the pinned version of requests to 2.9.1 (and 4.3.10 has 2.10.0),
conflicting with the "requests >= 0.9, < 1.0" pin here; see the history of https://github.com/plone/Installers-UnifiedInstaller/commits/4.3-maintenance/buildout_templates/buildout.cfg.
As this prevents the installation of medialog.issuu 0.3.3 (or of upgrading an existing Plone 4.3 with medialog.issuu installed) and 0.4 requires Plone 5, it is impossible to use medialog.issuu on the current version of Plone 4. I've fixed this by removing the version pin for requests, and it appears to work fine -- at least files in my site display properly.
Note: I created a
plone4branch from 4d67ba9 (the 0.3.3 release), then committed to that branch. I didn't have any branch choice besides your master when creating the PR, but it doesn't belong there and makes more sense as a separate branch. You should be able to copy my branch, and hopefully cut a 0.3.4 release to pypi if it looks good. Thanks!