Use IPADDR6_INIT() macro to set connecting IPv6 address

[dwmw2]

If LwIP is built with LWIP_IPV6_SCOPES, there is a 'zone' member in struct ip6_addr which was not being initialized correctly, leading to routing failures.

The tcp_connect() call would return ERR_RTE and we would completely fail to report that error. All the user would see is 'Connecting to MQTT...' over and over again.

[mathieucarbou]

@dwmw2 : I took the liberty to cherry-pick your fix in:

• https://github.com/mathieucarbou/AsyncTCP
• https://github.com/mathieucarbou/ESPAsyncWebServer

[HeMan]

Would the macro ip_addr_copy_from_ip6 give the same result? Otherwise, go with this.

[dwmw2]

Would the macro ip_addr_copy_from_ip6 give the same result? Otherwise, go with this.

No, I don't think there's a simpler option.

All this converting between in_addr_t and various Arduino and ESPHome C++ classes is kind of awful :)

[HeMan]

Would the macro ip_addr_copy_from_ip6 give the same result? Otherwise, go with this.

No, I don't think there's a simpler option.

All this converting between in_addr_t and various Arduino and ESPHome C++ classes is kind of awful :)

Yeah, I was hoping that the helper class in ESPHome would fix it all...

[dwmw2]

Would the macro ip_addr_copy_from_ip6 give the same result? Otherwise, go with this.

No, I don't think there's a simpler option.
All this converting between in_addr_t and various Arduino and ESPHome C++ classes is kind of awful :)

Yeah, I was hoping that the helper class in ESPHome would fix it all...

Yeah, that's part of my sadness. Its constructor which takes an arduino::IPAddress assumes it will be Legacy IP and converts via uint32_t... I'll take a look at that later.

After we merge this PR can we have a 2.1.4 release please? I'll then require it from esphome/esphome#7398

[HeMan]

@jesserockz ready for merge!

[dwmw2]

And v2.1.4 tag please

[esphome]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.