Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add disabled grove port power switch #194

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Add disabled grove port power switch #194

merged 3 commits into from
Nov 27, 2024

Conversation

jesserockz
Copy link
Member

The grove port 5v pin is activated only when GPIO46 of the ESP32-S3 is turned on.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2024

Firmware built successfully! 🎉

Download and extract the firmware to install with https://web.esphome.io

Make sure to choose home-assistant-voice-esp32s3.factory.bin.

balloob
balloob reviewed Nov 10, 2024
View reviewed changes
home-assistant-voice.yaml Outdated Show resolved Hide resolved
jesserockz
jesserockz commented Nov 10, 2024
View reviewed changes
home-assistant-voice.yaml Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Firmware built successfully! 🎉

Download and extract the firmware to install with https://web.esphome.io

Make sure to choose home-assistant-voice-esp32s3.factory.bin.

jlpouffier
jlpouffier requested changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@jlpouffier jlpouffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jesserockz Can you just add a small comment so that if people are reading and searching the groove port, they know what they need to do?

home-assistant-voice.yaml Show resolved Hide resolved
@esphome esphome bot marked this pull request as draft November 27, 2024 15:57
@esphome
Copy link

esphome bot commented Nov 27, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@balloob balloob marked this pull request as ready for review November 27, 2024 18:50
@esphome esphome bot requested a review from jlpouffier November 27, 2024 18:50
@github-actions GitHub Actions
Copy link

Firmware built successfully! 🎉

Download and extract the firmware to install with https://web.esphome.io

Make sure to choose home-assistant-voice-esp32s3.factory.bin.

@balloob balloob merged commit 3fc4d82 into dev Nov 27, 2024
11 checks passed
@balloob balloob deleted the jesserockz-2024-506 branch November 27, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balloob balloob balloob approved these changes

@jlpouffier jlpouffier Awaiting requested review from jlpouffier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jesserockz @balloob @jlpouffier