Skip to content
This repository was archived by the owner on Dec 3, 2020. It is now read-only.

chore: specify that both browsers are needed #14

Merged
merged 1 commit into from
Oct 21, 2019

Conversation

kuosmark
Copy link

@kuosmark kuosmark commented Oct 21, 2019

Summary

Dependencies

Testing instructions

Checklist for pull request creator

  • A task has been created for the PR on the Kanban board with necessary details filled (one task / repo)
  • The commits and commit messages adhere to version control conventions
  • The code is consistent with the existing code base
  • Tests have been written for the change
  • All tests pass (unit, e2e)
  • All code has been linted and there aren't any lint errors
  • The change has been tested in the browser with Firefox 59+, Chrome 66+
  • The change has been tested with a smaller screen (tablet)
  • The change conforms to the UX specifications
  • All translations have been added (fi, sv, en)
  • The code is self-documenting or has been documented sufficiently, e.g., in the README
  • The branch has been rebased against master before the PR was created

Checklist for pull request reviewer (copy to review text box)

- [ ] A task has been created for the PR on the Kanban board with necessary details filled (one task / repo)
- [ ] The commits and commit messages adhere to [version control conventions](https://voltti.atlassian.net/wiki/spaces/NUORA/pages/32999/Versionhallintak+yt+nn+t#Versionhallintak%C3%A4yt%C3%A4nn%C3%B6t-Commit-viestienmuotoilu)
- [ ] The code is consistent with the existing code base
- [ ] All changes in all changed files have been reviewed
- [ ] Tests have been written for the change
- [ ] All tests pass (unit, e2e)
- [ ] All code has been linted and there aren't any lint errors
- [ ] The change has been tested in the browser with Firefox 59+, Chrome 66+
- [ ] The change has been tested with a smaller screen (tablet)
- [ ] The change conforms to the [UX specifications](https://voltti.atlassian.net/wiki/spaces/NUORA/pages/74809369/UX)
- [ ] All translations have been added (fi, sv, en)
- [ ] The code is self-documenting or has been documented sufficiently, e.g., in the README
- [ ] The PR branch has been rebased against master and force pushed if necessary before merging

Copy link

@parssinen parssinen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • A task has been created for the PR on the Kanban board with necessary details filled (one task / repo)
  • The commits and commit messages adhere to version control conventions
  • The code is consistent with the existing code base
  • All changes in all changed files have been reviewed
  • Tests have been written for the change
  • All tests pass (unit, e2e)
  • All code has been linted and there aren't any lint errors
  • The change has been tested in the browser with Firefox 59+, Chrome 66+
  • The change has been tested with a smaller screen (tablet)
  • The change conforms to the UX specifications
  • All translations have been added (fi, sv, en)
  • The code is self-documenting or has been documented sufficiently, e.g., in the README
  • The PR branch has been rebased against master and force pushed if necessary before merging

@kuosmark kuosmark merged commit 4cb6156 into master Oct 21, 2019
@kuosmark kuosmark deleted the github-template-patch branch October 21, 2019 11:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants