This repository was archived by the owner on Dec 3, 2020. It is now read-only.
forked from City-of-Helsinki/linkedevents-ui
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delete russian, chinese and arabic from event presentation languages
change all names in front-end from linked events to espoo events
changes Helsinki's logo to Espoo's logo
changes Helsinki's logo to Espoo's logo
…frontend into customization
delete russian, chinese and arabic from event presentation languages
change all names in front-end from linked events to espoo events
changes Helsinki's logo to Espoo's logo
…frontend into customization
parssinen
approved these changes
Oct 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- A task has been created for the PR on the Kanban board with necessary details filled (one task / repo)
- The commits and commit messages adhere to version control conventions
- The code is consistent with the existing code base
- All changes in all changed files have been reviewed
- Tests have been written for the change
- All tests pass (unit, e2e)
- All code has been linted and there aren't any lint errors
- The change has been tested in the browser with Firefox 59+, Chrome 66+
- The change has been tested with a smaller screen (tablet)
- The change conforms to the UX specifications
- All translations have been added (fi, sv, en)
- The code is self-documenting or has been documented sufficiently, e.g., in the README
- The PR branch has been rebased against master and force pushed if necessary before merging
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Dependencies
Testing instructions
Checklist for pull request creator
Checklist for pull request reviewer (copy to review text box)