Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing requestFrom overloaded function #3232

Closed
jrockinl opened this issue Sep 19, 2019 · 5 comments
Closed

Missing requestFrom overloaded function #3232

jrockinl opened this issue Sep 19, 2019 · 5 comments
Labels
Status: Stale Issue is stale stage (outdated/stuck)

Comments

@jrockinl
Copy link

Hardware:

Board: ESP32 and ESP 8266
Core Installation version: all
IDE name: Arduino IDE
Flash Frequency: n/a
PSRAM enabled: n/a
Upload Speed: n/a
Computer OS: n/a

Description:

While trying to fix Arduino Due problem with a touch sensor MPR121, I found a function in the Wire library that handled the condition that failed. The MPR121 library did not handle I2C Restart bits properly and actually created a stop and a start. There are i2C devices that toss away data to be read if the read (preceded by a write of desired address) is not followed by Restart bit.

The fixed MPR121 library (Adafruit_MPR121) works for many boards now but seems if fails on ESP32 and ESP8266 because the Wire library doesn't have the following Arduino function:
uint8_t TwoWire::requestFrom(uint8_t address, uint8_t quantity, uint32_t iaddress, uint8_t isize, uint8_t sendStop)

Sketch:

MPR121test.zip

@stickbreaker
Copy link
Contributor

@jrockinl the official Arduino reference arduino.cc WireRequestFrom does not list that variant? Where is it defined?

It looks to me that adafruit made a variant of the Wire() object.

Chuck.

@jrockinl
Copy link
Author

jrockinl commented Sep 20, 2019 via email

@stickbreaker
Copy link
Contributor

@jrockinl It's not part of documented arduino/ArduinoCore-API .
Someone snuck it in, they are arguing about officially including it.

Chuck.

@stale
Copy link

stale bot commented Nov 19, 2019

[STALE_SET] This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: Stale Issue is stale stage (outdated/stuck) label Nov 19, 2019
@stale
Copy link

stale bot commented Dec 3, 2019

[STALE_DEL] This stale issue has been automatically closed. Thank you for your contributions.

@stale stale bot closed this as completed Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Stale Issue is stale stage (outdated/stuck)
Projects
None yet
Development

No branches or pull requests

2 participants