-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP32 Arduino BLE Refactoring #9878
Comments
ArduinoBLE already supports esp32. Only change to do here would be to configure BLE to be controller only and import the ArduinoBLE library, no Bluedroid or NimBLE required. |
Yes, it supports the ESP32-S3 module from the UNO R4 board and the boards that use Nina-W102 that has an ESP32 module. The idea here is to implement the ArduinoBLE API as part of ESP32 Arduino BLE Library as direct ESP-IDF calls, instead of using a UART to send and receive AT commands. |
It also has the VHCI driver here: https://github.com/arduino-libraries/ArduinoBLE/blob/98ff550988912ffbaeb1d877970e9e05f1de0599/src/utility/HCIVirtualTransport.cpp#L138 Added in arduino-libraries/ArduinoBLE#252 |
@h2zero - Thanks for the information!
I see, this is way to implement it with internal channel AT commands.
I like the table showing resource utilization after compiling the different libraries' respective scan example! |
related discussion: #9836 |
Hello @h2zero, I am contacting you as a Project Manager of Arduino ESP32 project. Our Team have been recently investigating the refactoring of BLE in our core and we also investigated your NimBle-Arduino library. As you know, we need to keep working solution also for Classic BT on ESP32 platform, but in general in case of implementing e.g. Matter, moving to NimBLE based implementation makes sense. As you proposed before, we would like to open this approach of reusing parts of your library in the core and we would like to ask if it is okay for you and also if you would like to help us with your contribution? We can share more details about our ideas of implementation and we will be more than happy to hear your thoughts regarding it. Rodrigo (@SuGlider) has his hands on this and has some suggestions already for BLE refactoting. Thanks in advance |
@VojtechBartoska sure, let's chat about it. |
@h2zero - I have to finish the Arduino Matter Library first and then we will talk here about the nimBLE refactoring. Thank you! |
So much for talking about this I guess lol. |
Hi @h2zero. It was an communication issue. In the future we will be more careful and improve in situations like this. Before moving forward with the PR is there anywhere we can chat (like Discord or something similar) to discuss it and align our views ? If there is anything we can do to help you, let us know! |
@h2zero, Thanks for the support! @lucasssvaz is now in charge of this migration project. The general idea is to keep both, Bluedroid and NimBLE codes, guarded by NimBLE would be the default option to be compiled within the Core static libraries and Bluedroid could be activated by At this point, we are analyzing the back compatibility and how it is compiled, and also running, based on all the Bluedroid current examples from ESP32 Arduino Library. Therefore, we are in early stages. Please feel free to participate directly here or with the open PR. |
Thanks @lucasssvaz and @SuGlider, I have some thoughts on this and we should definitely discuss it. You can reach me via the email in my profile and I am also on discord with the same username as here. |
@h2zero Sent you an email. Thanks! |
Related area
BLE refactoring using NimBLE
Hardware specification
Any
Is your feature request related to a problem?
This is part of an effort to improve ESP32 Arduino.
Describe the solution you'd like
Starting point for a BLE refactoring Plan.
Targets:
Suggestion:
Examples:
Describe alternatives you've considered
None.
Additional context
None.
I have checked existing list of Feature requests and the Contribution Guide
The text was updated successfully, but these errors were encountered: