-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compilation error with ESP IDF 5.1.1 (BSP-411) #242
Comments
Hi @HamitAkay, the v1.1.0 ST7796 driver uses a new parameter |
@Lzw655 ESP IDF 5.0.4 does not have |
@HamitAkay Actually ESP IDF 5.1 has |
Hi @valkuc, ESP-IDF release/v5.0 (v5.0.4) does have rgb_ele_order. |
@Lzw655 the link you posted is to the release/v5.0 branch, not to v5.0.4 tag. Here's the link to the same file of v5.0.4, it doesn't contain this feature: https://github.com/espressif/esp-idf/blob/v5.0.4/components/esp_lcd/include/esp_lcd_panel_vendor.h
Please note that each component declares the supported IDF version in the manifest file. If the supported version is specified as, say, >=4.4, then the component should work with both v5.0.3 and v5.0.4. So either the code shouldn't depend on a feature introduced in a bugfix release, or should have appropriate ifdefs to handle both versions. |
@igrr Got it. I will fix this by using a compatible name |
I downloaded IDF 5.1.1 almost a week ago and it worked fine until I updated st7796 to 1.1.0. Then as @Lzw655 mentioned I pulled the new changes from the ESP IDF repo and it works fine now. However, I agree with @igrr. The component says it works with IDF >=4.4 but even though I have 5.1.1 it still throws the error. |
Sorry for that. I will fix this right now. |
Meanwhile, the affected versions were yanked in component manager, so version solving will not pick them (unless the user explicitly requests them) |
I used the previous version with ESP IDF 5.1.1 and had no problem. After updating to 1.1.0, I get these error messages:
I checked esp_lcd_panel_dev_config_t in ESP IDF and in fact it doesn't have such a member.
The text was updated successfully, but these errors were encountered: