Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation error with ESP IDF 5.1.1 (BSP-411) #242

Closed
HamitAkay opened this issue Oct 28, 2023 · 11 comments · Fixed by #244
Closed

Compilation error with ESP IDF 5.1.1 (BSP-411) #242

HamitAkay opened this issue Oct 28, 2023 · 11 comments · Fixed by #244

Comments

@HamitAkay
Copy link

I used the previous version with ESP IDF 5.1.1 and had no problem. After updating to 1.1.0, I get these error messages:

esp_lcd_st7796.c:77:29: error: 'esp_lcd_panel_dev_config_t' has no member named 'rgb_ele_order'
esp_lcd_st7796.c:78:10: error: 'LCD_RGB_ELEMENT_ORDER_RGB' undeclared (first use in this function)

I checked esp_lcd_panel_dev_config_t in ESP IDF and in fact it doesn't have such a member.

@github-actions github-actions bot changed the title Compilation error with ESP IDF 5.1.1 Compilation error with ESP IDF 5.1.1 (BSP-411) Oct 28, 2023
@Lzw655
Copy link
Collaborator

Lzw655 commented Oct 28, 2023

Hi @HamitAkay, the v1.1.0 ST7796 driver uses a new parameter rgb_ele_order of esp_lcd_panel_dev_config_t, which was just updated in ESP-IDF v5.0 and v5.1 a few weeks ago. So please update your ESP-IDF to the up-to-date commit.

@valkuc
Copy link

valkuc commented Oct 28, 2023

Hi @HamitAkay, the v1.1.0 ST7796 driver uses a new parameter rgb_ele_order of esp_lcd_panel_dev_config_t, which was just updated in ESP-IDF v5.0 and v5.1 a few weeks ago. So please update your ESP-IDF to the up-to-date commit.

@Lzw655 ESP IDF 5.0.4 does not have rgb_ele_order in esp_lcd_panel_dev_config_t. That's why I raised #240

@valkuc
Copy link

valkuc commented Oct 28, 2023

@HamitAkay Actually ESP IDF 5.1 has LCD_RGB_ELEMENT_ORDER_RGB constant. See LCD_RGB_ELEMENT_ORDER_RGB, /*!< RGB element order: RGB */. You probably misconfigured your project.

@Lzw655
Copy link
Collaborator

Lzw655 commented Oct 30, 2023

Hi @HamitAkay, the v1.1.0 ST7796 driver uses a new parameter rgb_ele_order of esp_lcd_panel_dev_config_t, which was just updated in ESP-IDF v5.0 and v5.1 a few weeks ago. So please update your ESP-IDF to the up-to-date commit.

@Lzw655 ESP IDF 5.0.4 does not have rgb_ele_order in esp_lcd_panel_dev_config_t. That's why I raised #240

Hi @valkuc, ESP-IDF release/v5.0 (v5.0.4) does have rgb_ele_order.

@igrr
Copy link
Member

igrr commented Oct 30, 2023

@Lzw655 the link you posted is to the release/v5.0 branch, not to v5.0.4 tag. Here's the link to the same file of v5.0.4, it doesn't contain this feature: https://github.com/espressif/esp-idf/blob/v5.0.4/components/esp_lcd/include/esp_lcd_panel_vendor.h

the v1.1.0 ST7796 driver uses a new parameter rgb_ele_order of esp_lcd_panel_dev_config_t, which was just updated in ESP-IDF v5.0 and v5.1 a few weeks ago. So please update your ESP-IDF to the up-to-date commit

Please note that each component declares the supported IDF version in the manifest file. If the supported version is specified as, say, >=4.4, then the component should work with both v5.0.3 and v5.0.4. So either the code shouldn't depend on a feature introduced in a bugfix release, or should have appropriate ifdefs to handle both versions.

@Lzw655
Copy link
Collaborator

Lzw655 commented Oct 30, 2023

@igrr Got it. I will fix this by using a compatible name rgb_endian.

@valkuc
Copy link

valkuc commented Oct 30, 2023

@igrr Got it. I will fix this by using a compatible name rgb_endian.

@Lzw655 could you please also fix compilation on TAG version of 5.0.4 (#240)

@HamitAkay
Copy link
Author

I downloaded IDF 5.1.1 almost a week ago and it worked fine until I updated st7796 to 1.1.0. Then as @Lzw655 mentioned I pulled the new changes from the ESP IDF repo and it works fine now. However, I agree with @igrr. The component says it works with IDF >=4.4 but even though I have 5.1.1 it still throws the error.

@Lzw655
Copy link
Collaborator

Lzw655 commented Oct 30, 2023

@igrr Got it. I will fix this by using a compatible name rgb_endian.

@Lzw655 could you please also fix compilation on TAG version of 5.0.4 (#240)

Of course.

@Lzw655
Copy link
Collaborator

Lzw655 commented Oct 30, 2023

I downloaded IDF 5.1.1 almost a week ago and it worked fine until I updated st7796 to 1.1.0. Then as @Lzw655 mentioned I pulled the new changes from the ESP IDF repo and it works fine now. However, I agree with @igrr. The component says it works with IDF >=4.4 but even though I have 5.1.1 it still throws the error.

Sorry for that. I will fix this right now.

@tore-espressif
Copy link
Collaborator

Sorry for that. I will fix this right now.

Meanwhile, the affected versions were yanked in component manager, so version solving will not pick them (unless the user explicitly requests them)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants