Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bsp(ESP32-P4 EV): Update BSP for HW v1.4 + LCD EK79007 1024x600 #356

Merged
merged 1 commit into from
Aug 6, 2024
Merged

bsp(ESP32-P4 EV): Update BSP for HW v1.4 + LCD EK79007 1024x600 #356

merged 1 commit into from
Aug 6, 2024

Conversation

espzav
Copy link
Collaborator

@espzav espzav commented Jul 30, 2024 •
edited
Loading

ESP-BSP Pull Request checklist

  • Version of modified component bumped
  • CI passing

Change description

  • Update BSP for HW v1.4
  • Add support for LCD EK79007 1024x600 (selectable in menuconfig)
  • Allow to change color mode in menucinfig (RGB565/RGB888)

tore-espressif
tore-espressif approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@tore-espressif tore-espressif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the update! I left only 1 question

bsp/esp32_p4_function_ev_board/Kconfig Show resolved Hide resolved
Lzw655
Lzw655 approved these changes Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@Lzw655 Lzw655 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @espzav, thank you for the prompt support. I tested the display function, and it performed well. Could you also integrate support for the audio function?

bsp/esp32_p4_function_ev_board/esp32_p4_function_ev_board.c Show resolved Hide resolved
bsp/esp32_p4_function_ev_board/esp32_p4_function_ev_board.c Outdated Show resolved Hide resolved
bsp/esp32_p4_function_ev_board/esp32_p4_function_ev_board.c Show resolved Hide resolved
@espzav espzav force-pushed the bsp/esp32_p4_function_ev_v1.4 branch from 73a97b7 to 89fa96c Compare August 1, 2024 07:12
@espzav
Copy link
Collaborator Author

espzav commented Aug 1, 2024

@tore-espressif and @Lzw655 Thank you for review
About audio, I would like to support audio on this board. We are working on support new I2C NG driver, I think better will be support audio after that,

@espzav espzav force-pushed the bsp/esp32_p4_function_ev_v1.4 branch from 89fa96c to fed950c Compare August 2, 2024 08:15
@espzav
Copy link
Collaborator Author

espzav commented Aug 2, 2024

@tore-espressif @Lzw655 We have new discussion about considering initialization of ILI9881C and EK79007. I added new conditions into version for these components in idf_component.yml. We can merge it as it is and update it later or we can wait to considering it.
What do you thing?

@espzav espzav force-pushed the bsp/esp32_p4_function_ev_v1.4 branch from fed950c to 299be98 Compare August 2, 2024 10:04
@Lzw655
Copy link
Collaborator

Lzw655 commented Aug 5, 2024 •
edited
Loading

@tore-espressif Tested well! I think it's ready for merging.

@espzav espzav force-pushed the bsp/esp32_p4_function_ev_v1.4 branch from 299be98 to 1f0872c Compare August 6, 2024 12:01
@espzav espzav merged commit c903e51 into master Aug 6, 2024
18 checks passed
@espzav espzav deleted the bsp/esp32_p4_function_ev_v1.4 branch August 6, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lzw655 Lzw655 Lzw655 approved these changes

@tore-espressif tore-espressif tore-espressif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@espzav @Lzw655 @tore-espressif