Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please replace driver/i2c.h to driver/i2c_master.h in GT911 driver (BSP-544) #380

Closed
1 task done
jitenshap opened this issue Aug 25, 2024 · 1 comment · Fixed by #381
Closed
1 task done

Please replace driver/i2c.h to driver/i2c_master.h in GT911 driver (BSP-544) #380

jitenshap opened this issue Aug 25, 2024 · 1 comment · Fixed by #381
Labels
Status: Awaiting triage Type: Bug Something isn't working

Comments

@jitenshap
Copy link

Board

ESP32-P4-Function-EV-Board v1.4

Hardware Description

ESP32-P4-Function-EV-Board v1.4 and bundled LCD(GT911, EK79007)

IDE Name

VS Code

Operating System

Windows 11

Description

GT911 driver is include the #include "driver/i2c.h" header file.
Please use "driver/i2c_master.h".

Sketch

#include "bsp/esp32_p4_function_ev_board.h"

Other Steps to Reproduce

No response

I have checked existing issues, README.md and ESP32 Forum

  • I confirm I have checked existing issues, online documentation and Troubleshooting guide.
@jitenshap jitenshap added Status: Awaiting triage Type: Bug Something isn't working labels Aug 25, 2024
@github-actions github-actions bot changed the title Please replace driver/i2c.h to driver/i2c_master.h in GT911 driver Please replace driver/i2c.h to driver/i2c_master.h in GT911 driver (BSP-544) Aug 25, 2024
tore-espressif added a commit that referenced this issue Aug 26, 2024
@tore-espressif
fix(esp_lcd_touch): Remove i2c includes
5c64778 
All esp_lcd_touch drivers use I2C IO from esp_lcd,
they do not directly depend on I2C driver.

Closes #380
@tore-espressif tore-espressif mentioned this issue Aug 26, 2024
Merged
2 tasks
@tore-espressif
Copy link
Collaborator

Hello @jitenshap , thanks for the report. I think we can remove the include altogether. See #381

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Awaiting triage Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(esp_lcd_touch): Remove i2c includes espressif/esp-bsp
2 participants
@jitenshap @tore-espressif