Update LCD drivers #232
Merged
Update LCD drivers #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lzw655
force-pushed
the
feature/update_lcd_drivers
branch
6 times, most recently
from
e0eee16 to
45f077c
Compare
Lzw655
force-pushed
the
feature/update_lcd_drivers
branch
from
45f077c to
b710ab4
Compare
|
Hi @espzav @tore-espressif , I have updated some familiar LCD drivers and validated them through test_apps on the hardware. As for the other LCD drivers, I haven't made any changes as I'm not familiar with them and don't have the hardware for validation. PTAL, thank you! |
|
Hi @espzav @tore-espressif, PTAL, thank you! |
Lzw655
force-pushed
the
feature/update_lcd_drivers
branch
from
b710ab4 to
93c6844
Compare
Lzw655
force-pushed
the
feature/update_lcd_drivers
branch
from
93c6844 to
a6404d9
Compare
|
Hi. Any news when it's planned to merge this PR? |
tore-espressif
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Changes LGTM, but I did not have a chance to check on HW.
@espzav can you please have a brief look?
Lzw655
force-pushed
the
feature/update_lcd_drivers
branch
from
a6404d9 to
db65d71
Compare
|
@espzav ,PTAL. I plan to modify the screen init cmd of esp-box-3, which may be needed. Solved the problem of unclear screen display. |
|
@Lzw655 Thank you for this PR. Great job! LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESP-BSP Pull Request checklist
Change description