add esp32-s3-korvo-1 audio and sd card (BSP-446) #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tore-espressif @espzav PTAL |
github-actions
bot
changed the title
pborcin
force-pushed
the
feature/s3korvo1_audio
branch
from
7014e0e
to
8994b6c
Compare
There was a problem hiding this comment.
Thank you very much for the update @pborcin , I'd like to test on HW before we proceed with this MR.
2 more things:
- This BSP is not build in any CI job. You should add
sdkconfig.bsp.esp32_s3_korvo_1file to examples that should work on this BSP. Eg examples/audio - Audio for v4.4 will fail to build. Could you please have a look at that too?
|
@tore-espressif @espzav PTAL |
|
@pborcin I tried on HW and my audio playback is not working (no sound). Is there anything else I need to do to make it work? |
pborcin
force-pushed
the
feature/s3korvo1_audio
branch
4 times, most recently
from
e3fc8ad
to
9732df9
Compare
tore-espressif
approved these changes
Feb 28, 2024
tore-espressif
requested changes
Feb 28, 2024
pborcin
force-pushed
the
feature/s3korvo1_audio
branch
from
9732df9
to
7606674
Compare
tore-espressif
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESP-BSP Pull Request checklist