Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LCD ILI9881C: Supported LCD mirror. Not supported swap XY. #295

Merged
merged 1 commit into from
Feb 20, 2024
Merged

LCD ILI9881C: Supported LCD mirror. Not supported swap XY. #295

merged 1 commit into from
Feb 20, 2024

Conversation

espzav
Copy link
Collaborator

@espzav espzav commented Feb 16, 2024 •
edited
Loading

ESP-BSP Pull Request checklist

  • Version of modified component bumped
  • CI passing

Change description

Updated LCD ILI9881C initialization, set color mode. Add support for mirror x/y. Not supported swap XY by driver.

@espzav
Copy link
Collaborator Author

espzav commented Feb 19, 2024

@suda-morris Thank you for review. All fixed.

Lzw655
Lzw655 reviewed Feb 19, 2024
View reviewed changes
Copy link
Collaborator

@Lzw655 Lzw655 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @espzav, thank you for updating. According to my testing, both the RGB element order and mirror() only require the use of the 36h command, without needing to set 22h. Could you please confirm this again?

components/lcd/esp_lcd_ili9881c/esp_lcd_ili9881c.c Outdated Show resolved Hide resolved
@espzav espzav force-pushed the lcd/ili9881c_rotation branch 2 times, most recently from 73dc0bd to 22f83ec Compare February 19, 2024 11:29
@espzav
Copy link
Collaborator Author

espzav commented Feb 19, 2024

According to my testing, both the RGB element order and mirror() only require the use of the 36h command, without needing to set 22h. Could you please confirm this again?

Hi @Lzw655, Awesome! It is not in documentation, but it is working (inverted 22h). I tested before with LCD_CMD_MX_BIT and LCD_CMD_MY_BIT and it didn't work. With same bits, which was used on 22h register, it is working. I will change it in driver. Thank you!

@espzav
Copy link
Collaborator Author

espzav commented Feb 19, 2024

@tore-espressif PTAL

@espzav espzav merged commit 05d471a into master Feb 20, 2024
22 checks passed
@espzav espzav deleted the lcd/ili9881c_rotation branch February 20, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lzw655 Lzw655 Lzw655 left review comments

@suda-morris suda-morris suda-morris left review comments

@tore-espressif tore-espressif tore-espressif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@espzav @suda-morris @tore-espressif @Lzw655