Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): Extend noglib script to all BSPs #298

Merged
merged 1 commit into from
Feb 22, 2024
Merged

fix(ci): Extend noglib script to all BSPs #298

merged 1 commit into from
Feb 22, 2024

Conversation

tore-espressif
Copy link
Collaborator

Change description

Extend noglib python script so it

  • accepts multiple BSPs
  • renames the BSP automatically
  • check the dependency table in readme automatically

If you want to add a new noglib BSP, only 2 changes are needed:

  1. Add the BSP to this space separated list (eventually, this will include all BSPs)

    esp-bsp/.github/workflows/upload_component_noglib.yml

    Line 19 in c1fd146

    BSPs: "bsp/esp32_s3_eye"
  2. Add the noglib BSP to upload job

    esp-bsp/.github/workflows/upload_component_noglib.yml

    Line 25 in c1fd146

    directories: >

@tore-espressif tore-espressif self-assigned this Feb 21, 2024
espzav
espzav approved these changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@espzav espzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tore-espressif Thank you for fast update! LGTM

@tore-espressif tore-espressif merged commit 6606077 into master Feb 22, 2024
11 checks passed
@tore-espressif tore-espressif deleted the fix/generalize-noglib-script branch February 22, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@espzav espzav espzav approved these changes

Assignees

@tore-espressif tore-espressif

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tore-espressif @espzav