Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bsp: Add ESP32-P4 Function EV Board (supported LCD, USB, SD). #299

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

espzav
Copy link
Collaborator

@espzav espzav commented Feb 23, 2024

Checklist for new Board Support package or Component

  • Component contains License
  • Component contains README.md
  • Project README.md updated
  • Component contains idf_component.yml file with url field defined
  • Component was added to CI upload job
  • New files were added to CI build job
  • New BSP definitions added to bsp_ext.py
    - [ ] BSP was added to SquareLine
    - [ ] New BSP supports IDF v4.4.x and later releases
    - [ ] Optional: Component contains unit tests
  • CI passing

Change description

Please describe your change here

@espzav espzav force-pushed the bsp/esp32p4_function_ev_board branch 6 times, most recently from 3d8bcd9 to 1675932 Compare February 23, 2024 13:53
@espzav espzav force-pushed the bsp/esp32p4_function_ev_board branch from 1675932 to f4f97a6 Compare February 23, 2024 14:03
@espzav
Copy link
Collaborator Author

espzav commented Feb 23, 2024

@tore-espressif PTAL

@espzav espzav force-pushed the bsp/esp32p4_function_ev_board branch from f4f97a6 to 559b36d Compare February 26, 2024 07:31
Copy link
Collaborator

@tore-espressif tore-espressif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@espzav Here are some preliminary review comments/questions.

I will check the display part later this week :)

bsp/esp32_p4_function_ev_board/Kconfig Outdated Show resolved Hide resolved
bsp/esp32_p4_function_ev_board/Kconfig Outdated Show resolved Hide resolved
bsp/esp32_p4_function_ev_board/include/bsp/esp-bsp.h Outdated Show resolved Hide resolved
bsp/esp32_p4_function_ev_board/idf_component.yml Outdated Show resolved Hide resolved
bsp/esp32_p4_function_ev_board/include/bsp/esp32_p4.h Outdated Show resolved Hide resolved
bsp/esp32_p4_function_ev_board/include/bsp/esp32_p4.h Outdated Show resolved Hide resolved
bsp/esp32_p4_function_ev_board/include/bsp/esp32_p4.h Outdated Show resolved Hide resolved
@espzav espzav force-pushed the bsp/esp32p4_function_ev_board branch from 559b36d to 1758cc5 Compare February 26, 2024 09:31
@espzav
Copy link
Collaborator Author

espzav commented Feb 26, 2024

@tore-espressif Thank you for review. Everything fixed. Now, the P4 is working with LVGL9 too, but default is still LVGL8. We can change it in BSP YML.
I tried benchmark on LVGL9, there is another benchmark and result is another.
LVGL8 benchmark: weight FPS: 91
LVGL9 benchmark: FPS: 28 (seems that LVGL9 need more better settings)

@espzav espzav force-pushed the bsp/esp32p4_function_ev_board branch 10 times, most recently from 6bfc029 to 89fd9c2 Compare March 1, 2024 09:52
Copy link
Collaborator

@tore-espressif tore-espressif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@espzav espzav force-pushed the bsp/esp32p4_function_ev_board branch from 89fd9c2 to 0f9b4ea Compare March 1, 2024 12:00
@espzav espzav force-pushed the bsp/esp32p4_function_ev_board branch from 0f9b4ea to 7f3d116 Compare March 1, 2024 13:57
@espzav espzav merged commit 95368bd into master Mar 1, 2024
23 checks passed
@espzav espzav deleted the bsp/esp32p4_function_ev_board branch March 1, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants