-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically enable / disable FancyGraphics™ based on screen content #143
Comments
i have something very unpleasant to say to such a user |
So this is the only thing left that's priority—fancy graphics is still really slow for full screen redraws, and there's an abundance of tall characters; even # is taller than the cell size (by, like, a pixel) in whatever font Safari chose.
|
I think the only case where this matters are symbols / emoji that go outside the box horizontally. maybe I could add a checkbox to permanently enable it if people want it? And i guess we can move it out of priority… that's quite niche |
So, none of the above |
i mean if you get some genial idea to make it faster, that would be nice 🤷♂️ |
That's my ideas up there xD |
if it's faster than what we had and compatible with what we currently support ¯\_(ツ)_/¯ |
well it's actually fairly smooth, but fattens app.*.js up to be 110kB and doesn't support the custom character drawing stuff because I didn't bother adding it |
110 minified without demo? 👀 |
yeah, non-prod is 145k xD |
I'll push it to a new branch |
mmk but i don't think we should merge that in this state |
there's no need to redraw or even check cursor neighborhood if we know there are no wide/tall characters on the screen at all
(tall characters may be tricky to detect, but i think they're gonna be rare. maybe 𝄞 ? could have a list of the more common ones...)
a similar mechanism for counting can be used as is now employed to count blinky cells
The text was updated successfully, but these errors were encountered: