Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto reload only works on /pages #2

Open
ionflow opened this issue Jan 23, 2017 · 3 comments
Open

Auto reload only works on /pages #2

ionflow opened this issue Jan 23, 2017 · 3 comments

Comments

@ionflow
Copy link

ionflow commented Jan 23, 2017

After running npm run serve

Only updates to /pages trigger a reload which can be annoying when you're working in the /partials or /layouts folder.

Running npm run build triggers a build which refreshes the browser. One extra step.

@esr360
Copy link
Owner

esr360 commented Jan 23, 2017

The reason this is the case, is because when editing a file in /pages, we know which template/page we need to compile (which is what will trigger the refresh). If making changes to a partial or layout, we don't know which page we are currently working on, so we would have to re-compile every template available. The project I initially built this for had over 100 templates - compiling all these templates every time I changed a partial/layout proved to be inefficient.

This is a valid issue, though. You should be able to make a change to a partial or layout and trigger a refresh on the page you're working on - I'm sure it is possible, will just need further investigation.

@jklemm
Copy link
Contributor

jklemm commented Aug 1, 2017

I note this when coding. The same occurs with images folder, putting new images in this folder don't run the images task to copy to dist. But even so, Noah is being very helpful to me.

Want to help you guys with dev/bugs! 👍

@esr360
Copy link
Owner

esr360 commented Aug 3, 2017

Thanks for the feedback @jklemm, it is much appreciated. I will happily accept pull requests whilst I'm working on my other project, One-Nexus. Otherwise I will be coming back to work on Noah in the near future :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants