Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed ImageFile to UploadFile and modified iOS actual to use NSData instead of UIImage #60

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

rohitst
Copy link
Contributor

@rohitst rohitst commented Mar 10, 2024

A PR for issue #59

The change is breaking, but I think it's worth it.

  • Made putObject take an a generic 'UploadFile' instead of image
  • Renamed ImageFile to UploadFile
  • Changed UploadFile iOS implementation to be backed with NSData instead of UIImage.
  • Added an extension UIImage.toPNGUploadFile() to support the image case on iOS

@rohitst rohitst requested a review from estivensh as a code owner March 10, 2024 10:36
Copy link
Owner

@estivensh estivensh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, I will be making some changes so that in the samples folder we can see the instantaneous changes of the modules and not have to wait for a new version.

@estivensh estivensh merged commit 2d3c1f8 into estivensh:main Mar 14, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants