Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not bundle estraverse dependency? #104

Closed
nikaspran opened this issue Apr 29, 2020 · 1 comment
Closed

Do not bundle estraverse dependency? #104

nikaspran opened this issue Apr 29, 2020 · 1 comment

Comments

@nikaspran
Copy link
Contributor

nikaspran commented Apr 29, 2020

I'd like to suggest creating another rollup artifact without the bundled estraverse.

This would have a few advantages:

  1. Smaller footprint if estraverse is already included in dependencies of the project that brings this in.
  2. Allow modifying estraverse.VisitorKeys, which would allow using esquery with things like TypeScript and JSX (and be a sensible workaround for Add optional JSX-Support while keeping original behaviour the default #57)
  3. Work more canonically with Node.js projects (i.e. ability to use require cache, dependency resolutions and so on)

If this works, I can prepare a small PR over the next few days. To keep backwards compatibility, I can set it up as a new output artifact that wouldn't impact anything - would that work?

@michaelficarra
Copy link
Member

Fixed by #105.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants