Add id to CTA links and buttons #688
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brenosalv
added
the
generate-pr-preview
|
Visit the preview URL for this PR (updated for commit fcb6e14): https://estuary-marketing--pr688-brenosalv-feature-65-llsypbk4.web.app (expires Sat, 08 Mar 2025 18:00:50 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 76f6b095a0752e5d9c6c890267f9fdc3e392161e |
|
@danthelion I added id to all the CTA buttons, trying to cover all the buttons and links that might be important to track. I think we could add id to menu links as well. What do you think? |
|
@danthelion Is it possible to test the buttons/links before merging? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#651
Changes
Tests / Screenshots
Two examples: