Skip to content

Commit

Permalink
Update storage mapping provider label for amazon s3 (#1463)
Browse files Browse the repository at this point in the history
  • Loading branch information
kiahna-tucker authored Feb 12, 2025
1 parent e624224 commit 4ab35c3
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 13 deletions.
14 changes: 3 additions & 11 deletions playwright-tests/tests/admin.spec.ts
Original file line number Diff line number Diff line change
@@ -1,15 +1,7 @@
import { expect, test, Page } from '@playwright/test';
import { beforeEach } from 'node:test';
import { expect, Page, test } from '@playwright/test';
import { AuthProps } from '../helpers/types';
import { USERS } from '../helpers/users';
import {
defaultLocalStorage,
defaultPageSetup,
emailDomain,
inituser,
startSessionWithUser,
saveAndPublish,
} from '../helpers/utils';
import { defaultPageSetup } from '../helpers/utils';

const invalidEmail = 'Fake_Invalid_Email';
const testTokens = ['test token 1', 'test token 2', 'test token 3'];
Expand Down Expand Up @@ -158,7 +150,7 @@ test.describe.serial('Admin:', () => {
await page.getByRole('combobox', { name: 'Provider' }).click();
await page
.getByRole('option', {
name: 'Amazon Simple Storage Service',
name: 'Amazon S3',
})
.click();
await expect(page.getByLabel('Bucket *')).toBeVisible();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ const gcsProviderSchema = {
};

const s3ProviderSchema = {
title: 'Amazon Simple Storage Service.',
title: 'Amazon S3.',
examples: [
{
bucket: 'my-bucket',
Expand Down
2 changes: 1 addition & 1 deletion src/lang/en-US/AdminPage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ export const AdminPage: Record<string, string> = {
'storageMappings.dialog.generate.providerOption.AZURE': `Azure Object Storage Service`,
'storageMappings.dialog.generate.providerOption.CUSTOM': `An S3-compatible Endpoint`,
'storageMappings.dialog.generate.providerOption.GCS': `Google Cloud Storage`,
'storageMappings.dialog.generate.providerOption.S3': `Amazon Simple Storage Service`,
'storageMappings.dialog.generate.providerOption.S3': `Amazon S3`,
'storageMappings.dialog.generate.logsHeader': `Please wait while we save and apply your storage mapping.`,
'storageMappings.dialog.generate.error.republicationFailed': `There was an error republishing the entities in your system. Please try again.`,
'storageMappings.dialog.generate.error.unableToFetchLogs': `There was an issue fetching the logs when applying the new storage mapping. Please contact support to confirm that your system has been updated accordingly.`,
Expand Down

0 comments on commit 4ab35c3

Please sign in to comment.