Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wishbone b3 #61

Open
stdefeber opened this issue Jun 26, 2024 · 3 comments
Open

Add wishbone b3 #61

stdefeber opened this issue Jun 26, 2024 · 3 comments
Labels
kind: feature New feature or request of enhancement scope: hw generators Related to HDL generators status: todo Planned for implementation
Milestone

Comments

@stdefeber
Copy link

Although very similar to Avalon, would it be possible to add a Wishbone B3 compliant interface ?

@stdefeber
Copy link
Author

I have been working on this issue myself.
Although generation seems to be fine I cannot verify the changes since there is some dependency on Win32 packages ?

@martijnbastiaan
Copy link

I don't see any Windows-specific dependencies in setup.py. Could you elaborate @stdefeber? What commands are you issuing? What errors do you see?

@stdefeber
Copy link
Author

stdefeber commented Jul 22, 2024

My assumption could definitely be wrong.
However, some searches come up with stackoverflow threads mentioning Windows and keywords in the error messages being AnsiToWin32Test , mockWin32, win32.STDOUT

Command issued:

python3 -m pytest -v -n auto

I am running corsair in a virtual environment.

The errors I get, during the tests, are:

[gw2] [ 32%] FAILED lib/python3.12/site-packages/pip/_vendor/colorama/tests/ansitowin32_test.py::AnsiToWin32Test::test_native_windows_ansi 
lib/python3.12/site-packages/pip/_vendor/colorama/tests/ansitowin32_test.py::AnsiToWin32Test::test_osc_codes 
[gw2] [ 32%] FAILED lib/python3.12/site-packages/pip/_vendor/colorama/tests/ansitowin32_test.py::AnsiToWin32Test::test_osc_codes 
lib/python3.12/site-packages/pip/_vendor/colorama/tests/ansitowin32_test.py::AnsiToWin32Test::test_reset_all_shouldnt_raise_on_closed_orig_stdout 

and while gathering final info, just to grep 1:

__________________________________________________________ WinTermTest.testSetConsole __________________________________________________________
[gw1] linux -- Python 3.12.3 /home/stdefeber/projects/corsair/.venv/bin/python3

self = <pip._vendor.colorama.tests.winterm_test.WinTermTest testMethod=testSetConsole>
mockWin32 = <MagicMock name='win32' id='128564182793776'>

    @patch('colorama.winterm.win32')
    def testSetConsole(self, mockWin32):
        mockAttr = Mock()
        mockAttr.wAttributes = 0
        mockWin32.GetConsoleScreenBufferInfo.return_value = mockAttr
>       term = WinTerm()

lib/python3.12/site-packages/pip/_vendor/colorama/tests/winterm_test.py:104: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <pip._vendor.colorama.winterm.WinTerm object at 0x74edae743620>

    def __init__(self):
>       self._default = win32.GetConsoleScreenBufferInfo(win32.STDOUT).wAttributes
E       AttributeError: module 'pip._vendor.colorama.win32' has no attribute 'GetConsoleScreenBufferInfo'

lib/python3.12/site-packages/pip/_vendor/colorama/winterm.py:31: AttributeError

pip list

shows that colorama is installed.

@esynr3z esynr3z changed the title #enhancement : add wishbone b3 Add wishbone b3 Oct 5, 2024
@esynr3z esynr3z added kind: feature New feature or request of enhancement new New issue not seen by maintainers scope: hw generators Related to HDL generators labels Oct 5, 2024
@esynr3z esynr3z added this to the v2.x backlog milestone Oct 5, 2024
@esynr3z esynr3z added status: todo Planned for implementation and removed new New issue not seen by maintainers labels Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: feature New feature or request of enhancement scope: hw generators Related to HDL generators status: todo Planned for implementation
Projects
None yet
Development

No branches or pull requests

3 participants