Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for parametrized unpacked arrays #66

Open
g-lesssard opened this issue Aug 28, 2024 · 1 comment
Open

Support for parametrized unpacked arrays #66

g-lesssard opened this issue Aug 28, 2024 · 1 comment
Labels
kind: feature New feature or request of enhancement scope: register map Related to register map structure and representation status: todo Planned for implementation
Milestone

Comments

@g-lesssard
Copy link

Hi! I really like the project and would see a ton of use for it in our FPGA/ASIC projects. However, one blocker I see is the lack of parameters on the HDL modules generated. I often have multiple instances of a module that I would like to share the same register bank. For this I often have modules that look like this in Verilog:

module registers #(
   parameter DATA_W = 32,
   parameter INSTANCE_COUNT = 8
) (
...
output [INSTANCE_COUNT-1:0] control_reg [DATA_W-1:],
...
);

I would this type of Register to be supported by corsair. This is a larger feature request that I would be happy to collaborate to. I would like your feedback on how best to include this. I was thinking of adding a class like UnpackedRegisters that would take in input a Register object and a name for its parameter.

Is this a feature that you would like to be supported and is my proposed approach in line to how you would approach the issue?

@esynr3z esynr3z added kind: feature New feature or request of enhancement scope: register map Related to register map structure and representation new New issue not seen by maintainers labels Oct 5, 2024
@esynr3z esynr3z added this to the v2.x backlog milestone Oct 5, 2024
@esynr3z
Copy link
Owner

esynr3z commented Oct 12, 2024

Hi! Indeed, this is frequently requested feature. I thought about it myself when creating 1.0, but in order to simplify things it was postponed. Now I'm working on 2.0 and this a good time to make some architectural tweaks to facilitate this kind of feature integration in the future.

@esynr3z esynr3z added status: todo Planned for implementation and removed new New issue not seen by maintainers labels Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: feature New feature or request of enhancement scope: register map Related to register map structure and representation status: todo Planned for implementation
Projects
None yet
Development

No branches or pull requests

2 participants