Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to override csrconfig values via cli #84

Open
esynr3z opened this issue Oct 8, 2024 · 0 comments
Open

Add option to override csrconfig values via cli #84

esynr3z opened this issue Oct 8, 2024 · 0 comments
Assignees
Labels
kind: feature New feature or request of enhancement scope: cli Related to CLI and configuration parsing status: todo Planned for implementation
Milestone

Comments

@esynr3z
Copy link
Owner

esynr3z commented Oct 8, 2024

It would be nice to have a way to override configuration parameters via CLI.
This facilitates scripting and experimenting around tool without modifying the configuration file.

It is quite a general feature that improves user experience with any configfile-oriented tools (which Corsair is). It also greatly simplifies CI, because otherwise when some tweaked configuration is required you either have to have multiple configuration files stored or modify it on-flight following parse-modify-dump flow.

Interface for that feature could be quite simple and could follow the same pattern used in git config. Consider this

git config --global user.email "[email protected]"

So user.emal is actually section and key within configuration file.

This would work for Corsair too. Following can override original parameters for the current run without touching the file:

corsair --set-config globcfg.base_address 0x1000 --set-config adoc.print_conventions false
@esynr3z esynr3z added kind: feature New feature or request of enhancement scope: cli Related to CLI and configuration parsing labels Oct 8, 2024
@esynr3z esynr3z added this to the v2.0.0 milestone Oct 8, 2024
@esynr3z esynr3z self-assigned this Oct 8, 2024
@esynr3z esynr3z added the status: todo Planned for implementation label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: feature New feature or request of enhancement scope: cli Related to CLI and configuration parsing status: todo Planned for implementation
Projects
None yet
Development

No branches or pull requests

1 participant