Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit number of results #732

Open
palvarez89 opened this issue Apr 29, 2020 · 4 comments
Open

Limit number of results #732

palvarez89 opened this issue Apr 29, 2020 · 4 comments

Comments

@palvarez89
Copy link
Member

We don't have any limits when storing data of previous draws. Limiting them to a low number, like 20, could help us save space in the database, and speed up page loads of draws with hundreds of them.

yes, some of them are quite large.

@mariocj89
Copy link
Member

I think a better approach might be to just delete old ones. We could delete draws altogether older than 3 o 6 months.

The reason why I prefer this is that users might do a draw across many users and generate many results (as we were doing at PyCon).

@palvarez89
Copy link
Member Author

Oh, yeah, I get that use case. The idea would be to delete the oldest result once you pass the limit.

Deleting old ones is a good idea too. I wonder if we have any information about when what last viewed, to use that instead of creation/last draw date?

@mariocj89
Copy link
Member

You opened this issue in the legacy EAS, just to confirm, we want to do this only in the new version, right?

We should just remove the old one.

@palvarez89
Copy link
Member Author

This is only an issue in legacy eas IIUC, current doesn't store multiple results per draw. Opened the issue as it could improve stability, as killing legacy doesn't look like it's happening soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants