[augerctl] Support shortname and check namespace for built-in resource #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wzshiming The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
wzshiming
force-pushed
the
feat/shortname
branch
20 times, most recently
from
cca0d04
to
7e9e20c
Compare
wzshiming
changed the title
wzshiming
force-pushed
the
feat/shortname
branch
from
7e9e20c
to
c36f2f7
Compare
Signed-off-by: Shiming Zhang <[email protected]>
wzshiming
force-pushed
the
feat/shortname
branch
from
c36f2f7
to
d604639
Compare
|
/cc @jmhbnz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/kubernetes/kubernetes/blob/eebc897e4fd8bf26a69d322c8dbcdf4da475934e/pkg/registry/apps/deployment/storage/storage.go#L122-L124
The short names of the built-in resources are hard-coded into the function, and there's no elegant way to get them, so the implementation here is a script that gets all the built-in resource information from the apiserver.