Fix use of useAppState outside preact context #203
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: https://wrap.sentry.io/issues/5568127635/?alert_rule_id=12711401&alert_type=issue¬ification_uuid=20b9d956-1665-4a68-83cf-df8be230b342&project=6237470&referrer=slack
In the stack trace the problem points at "images/map.svg".
I'm guessing it is because
locator-map-svg
was a shadow dom web component that Safari must initially load outside of Preact context which causes the issue becauseuseAppState()
would return undefined if it's not loaded inside the component tree with the AppState.Provider above it.There's no reason for this to be a shadow dom web component, this is one of the earliest components in the app and I think there was a reason at some point but it got refactored out so its been converted to a plan Preact template + css component instead.