Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust Geolocation error handling #205

Conversation

DanWebb
Copy link
Member

@DanWebb DanWebb commented Jul 12, 2024

Logs errors for geolocation
Handles missing coordinates
And possibility of submit() throwing

@DanWebb DanWebb self-assigned this Jul 12, 2024
@mergify mergify bot requested review from Carl-J-M and gavmck July 12, 2024 13:37
Copy link

github-actions bot commented Jul 12, 2024

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 1 0 0.01s
✅ REPOSITORY checkov yes no 21.18s
⚠️ REPOSITORY gitleaks yes 6 2.7s
✅ REPOSITORY git_diff yes no 0.03s
✅ REPOSITORY secretlint yes no 1.9s
✅ REPOSITORY trivy-sbom yes no 2.23s
✅ REPOSITORY trufflehog yes no 45.8s
✅ TSX eslint 1 0 7.55s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

sonarcloud bot commented Jul 12, 2024

@mergify mergify bot merged commit a084217 into main Jul 12, 2024
7 checks passed
@mergify mergify bot deleted the feature/wrap-739-use-my-location-breaks-if-you-are-outside-of-the-uk branch July 12, 2024 13:51
@DanWebb
Copy link
Member Author

DanWebb commented Jul 12, 2024

🎉 This PR is included in version 1.51.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants