Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix map button out of position #219

Merged

Conversation

DanWebb
Copy link
Member

@DanWebb DanWebb commented Oct 3, 2024

The map button was attaching itself to the browser viewport instead of the locator widget.

Screenshot 2024-10-02 at 17 08 14

This adds a dummy transform to create a new containing block so that the fixed element is forced inside.

Regarding the actual issue, I'm not exactly sure why this seemingly randomly started happening, my guess is a browser update related to shadow DOM?

@DanWebb DanWebb self-assigned this Oct 3, 2024
Copy link

sonarcloud bot commented Oct 3, 2024

@mergify mergify bot requested review from Carl-J-M and ella-etch October 3, 2024 10:03
Copy link

github-actions bot commented Oct 3, 2024

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ CSS stylelint 1 0 1.1s
✅ EDITORCONFIG editorconfig-checker 1 0 0.01s
✅ REPOSITORY checkov yes no 18.72s
⚠️ REPOSITORY gitleaks yes 6 2.23s
✅ REPOSITORY git_diff yes no 0.02s
✅ REPOSITORY secretlint yes no 1.75s
✅ REPOSITORY trivy-sbom yes no 2.4s
✅ REPOSITORY trufflehog yes no 26.96s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@DanWebb DanWebb merged commit 67af5db into main Oct 3, 2024
7 checks passed
@DanWebb DanWebb deleted the feature/wrap-888-show-map-button-incorrect-positioning branch October 3, 2024 10:07
@DanWebb
Copy link
Member Author

DanWebb commented Oct 3, 2024

🎉 This PR is included in version 1.52.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants