Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigating moving from inline sourcemap to external sourcemap #731

Open
luxaritas opened this issue Nov 6, 2023 · 1 comment
Open
Labels
priority: p4/minor There is a reasonable workaround, or there is a nice to have with limited impact size: sm type: enhancement New feature or request

Comments

@luxaritas
Copy link
Member

luxaritas commented Nov 6, 2023

The sourcemap is a pretty sizable chunk of the JS file being downloaded. I'm not sure why I opted to use inline sourcemaps, but (namely for performance reasons) we should probably serve sourcemaps separately and allow them to be loaded on demand

@luxaritas luxaritas added type: enhancement New feature or request size: sm priority: p4/minor There is a reasonable workaround, or there is a nice to have with limited impact labels Nov 6, 2023
@luxaritas luxaritas added this to Roadmap Nov 6, 2023
@github-project-automation github-project-automation bot moved this to Todo in Roadmap Nov 6, 2023
@luxaritas
Copy link
Member Author

I was originally thinking "on demand" would be "whenever we run into an error", but most likely/unfortunately that wouldn't be sufficient, given 1) how we currently deploy, the sourcemap for that version of code may no longer be available (as we only keep assets for the current and previous deployed version) and 2) for the PWA, the sourcemap would not be available while offline (assuming an error hasnt been triggered with that code version). That said, we can still defer loading it to not block application load (and even not happen concurrently when loading other assets to speed that up).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p4/minor There is a reasonable workaround, or there is a nice to have with limited impact size: sm type: enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

1 participant