Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a link to a diff from original SAFE code. #18

Open
MicahZoltu opened this issue Dec 15, 2024 · 2 comments
Open

Provide a link to a diff from original SAFE code. #18

MicahZoltu opened this issue Dec 15, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@MicahZoltu
Copy link

What is the feature about

In the readme it says that this is a fork safe-global/safe-wallet-web v1.27.0, but if you try to diff this repository and that one via GitHub it says nothing to compare. It would be helpful if the readme contained a diff that could be looked at if this is in fact a fork of another well known repository.

The list of requirements

Online diff of this repository and its base if relevant.

Links

safe-global/safe-wallet-monorepo@v1.27.0...eternalsafe:wallet:eternalsafe

@MicahZoltu MicahZoltu added the enhancement New feature or request label Dec 15, 2024
@devanoneth
Copy link
Contributor

This is a great idea, thanks for suggesting! I've noticed that actually I forked from v1.26.2, not 1.27.0, so I've fixed that in the README.

And funnily enough, the diff works when I use eternalsafe/wallet as the base, but not the other way around 🤔
https://github.com/eternalsafe/wallet/compare/eternalsafe..safe-global:safe-wallet-web:v1.26.2

I'm not quite sure why. I could include this link, but the diff POV is essentially reversed. What do you think?

@MicahZoltu
Copy link
Author

Huh, that is very odd. Too bad there isn't any reasonable way to submit a bug report to GitHub. 😖 I think it is worth including the link, but with a note that the diff is all backward for the reason stated above. Maybe also include the inverse comparison link and just mention that it is broken for some reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants