New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ethereum logo fetched from safe.global. #19

Open

MicahZoltu opened this issue Dec 15, 2024 · 1 comment

Labels

bug

MicahZoltu commented Dec 15, 2024

Environment

Browser: Firefox
Wallet: N/A
Chain: Ethereum mainnet

Steps to reproduce

Use the app.
Monitor the network tab.
Notice that the Ethereum logo is fetched from safe.global

Expected result

All resources, especially static ones, are part of the static site.

Obtained result

A GET request to https://safe-transaction-assets.safe.global/chains/1/currency_logo.png is made.

Screenshots

MicahZoltu added the bug label

Author

MicahZoltu commented Dec 15, 2024

I suspect it is caused by this:

wallet/src/config/supportedChains.ts

Line 17 in 4422fdd

    
           logoUri: 'https://safe-transaction-assets.safe.global/chains/1/currency_logo.png',

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment