Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coroutine raised StopIteration ci-runner error #62

Closed
valefar-on-discord opened this issue Jun 7, 2024 · 6 comments
Closed

Coroutine raised StopIteration ci-runner error #62

valefar-on-discord opened this issue Jun 7, 2024 · 6 comments
Assignees

Comments

@valefar-on-discord
Copy link
Collaborator

valefar-on-discord commented Jun 7, 2024

After landed #48 I noticed the ci-runner failed with a non-assertion error but a RuntimeError: coroutine raised StopIteration
https://github.com/valefar-on-discord/ethstaker-deposit-cli/actions/runs/9331869782/job/25687038382

I tried to reproduce this locally to no avail and I haven't seen it since from git actions but something to keep a look out for

@valefar-on-discord
Copy link
Collaborator Author

@remyroy
Copy link
Member

remyroy commented Jun 10, 2024

@remyroy
Copy link
Member

remyroy commented Jun 12, 2024

This seems to be related to the use of pipes in asyncio.create_subprocess_shell. The only tests failing are those that uses pipes (only 2, test_script_abbreviated_mnemonic and test_script_bls_withdrawal in tests/test_cli/test_new_mnemonic.py)

@yorickdowne
Copy link

">Is there a way/workaround to get this fixed in python 3.8 and python 3.9?

The patch should be easy enough to back port, but that's not something we'll do because this is not a security issue.

In your own code you could monkey patch multiprocessing, in particular by patching the Listener class to use a larger backlog."

python/cpython#101225

@yorickdowne
Copy link

yorickdowne commented Aug 27, 2024

I think we can reasonably wontfix this. It doesn't impact running deposit on macOS with Python 3.9, just the test suite. If we're keen we can exclude two tests on that platform.

Trying out a more granular skip in #104

@yorickdowne
Copy link

I'm closing this as wontfix: The workaround of skipping those two tests on macOS Python 3.9 seems reasonable to me, and Python 3.9 is not getting the fix for it back-ported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants