AA-446: Separate 'nonce' into two 256-bit values 'nonceKey' and 'nonceSequence' #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drortirosh
reviewed
Sep 18, 2024
shahafn
reviewed
Oct 21, 2024
|
|
||
| // Load nonce from storage | ||
| nonce := or(shl(64, key), sload(keccak256(0x04, 0x30))) | ||
| nonce := sload(keccak256(0x00, 0x34)) |
shahafn
reviewed
Oct 21, 2024
| @@ -26,22 +33,21 @@ contract NonceManager { | |||
| /// @return nonce a full nonce to pass for next transaction with given sender and key. | |||
shahafn
reviewed
Oct 21, 2024
|
|
||
| // Calculate storage slot and load current nonce | ||
| let nonceSlot := keccak256(0x04, 0x30) | ||
| let nonceSlot := keccak256(0x00, 0x34) |
There was a problem hiding this comment.
Fix name, either nonceKey or nonceSeq
shahafn
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.