Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L2 Transaction Fee API specification #53

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

Therecanbeonlyone1969
Copy link
Collaborator

Testability requirements will be added once all requirements have been agreed upon.

- API 3.0 api spec
- Requirements per API
- to proprety is not required in transactionCall
- updated currency property to reflect ability to specify native tokens and fiat currencies based on operator choice/offering.
@Therecanbeonlyone1969 Therecanbeonlyone1969 changed the title Initial L2 Transaction Fee API specification Initial Draft of L2 Transaction Fee API specification Apr 2, 2024
@CLAassistant
Copy link

CLAassistant commented Apr 8, 2024

CLA assistant check
All committers have signed the CLA.

@Therecanbeonlyone1969 Therecanbeonlyone1969 changed the title Initial Draft of L2 Transaction Fee API specification Draft of L2 Transaction Fee API specification May 8, 2024
@lgingerich
Copy link
Contributor

I approve this draft

- Added definition of transaction status
- Added minimal set of transaction statuses.
- Updated requirement on `transactionStatus` data property (R4) with minimal ste of transaction statuses.
- Added definitions of minimal set of L2 transaction statuses
- changed wording on `gasPrice` requirement from number to integer
Copy link

@realcodywburns realcodywburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no objections or comments. Looks good to me.

…ecific L2 client implementations

We will revisit the status naming in a separate standard on L2 transaction status nomenclature.

Previous Definitions:
We define the minimal set of transaction statuses as follows:

- Pending: An L2 transaction submitted to an L2, and waiting to be processed
- Replaced: An L2 transaction that was "Pending" was replaced by another L2 transaction
- Dropped: An L2 transaction that was removed from the L2 processing queue
- Success: A Pending L2 transaction has been included into an L2 block
- Finalized: An L2 transaction included in a L2 block that has been finalized on an L1.

Note, that the first four statuses are analogous to L1 transaction statuses. Note also, that there is still the possibility of an L1 reorganization that could revert the status of an L2 transaction back to success. Also at the time of writing, there is no possibility of an L2 reorganization unless through a malicious attacker.

Finally, more fine-grained statuses such as "Pending L1 Finalization" could be introduced to deliver more insights to end-user and improve the user experience.
@Therecanbeonlyone1969
Copy link
Collaborator Author

@smartcontracts @DZGoldman @t0mcr8se @0x000hx @leeederek -- please, review and approve this PR ASAP. Thank you!

@Therecanbeonlyone1969 Therecanbeonlyone1969 changed the title Draft of L2 Transaction Fee API specification L2 Transaction Fee API specification Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants