-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L2 Transaction Fee API specification #53
Open
Therecanbeonlyone1969
wants to merge
20
commits into
main
Choose a base branch
from
patch-7-l2-transaction-fee-api-spec
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- API 3.0 api spec - Requirements per API
- to proprety is not required in transactionCall - updated currency property to reflect ability to specify native tokens and fiat currencies based on operator choice/offering.
Therecanbeonlyone1969
changed the title
Initial L2 Transaction Fee API specification
Initial Draft of L2 Transaction Fee API specification
Apr 2, 2024
Added testability criteria for R1 - R5 (all API requirements).
…ussion - clarified the scope of the API with regard to Meta Transactions and User Actions in account abstraction - fixed some typos in the data schema.
Therecanbeonlyone1969
changed the title
Initial Draft of L2 Transaction Fee API specification
Draft of L2 Transaction Fee API specification
May 8, 2024
I approve this draft |
- Added definition of transaction status - Added minimal set of transaction statuses. - Updated requirement on `transactionStatus` data property (R4) with minimal ste of transaction statuses. - Added definitions of minimal set of L2 transaction statuses - changed wording on `gasPrice` requirement from number to integer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no objections or comments. Looks good to me.
…ecific L2 client implementations We will revisit the status naming in a separate standard on L2 transaction status nomenclature. Previous Definitions: We define the minimal set of transaction statuses as follows: - Pending: An L2 transaction submitted to an L2, and waiting to be processed - Replaced: An L2 transaction that was "Pending" was replaced by another L2 transaction - Dropped: An L2 transaction that was removed from the L2 processing queue - Success: A Pending L2 transaction has been included into an L2 block - Finalized: An L2 transaction included in a L2 block that has been finalized on an L1. Note, that the first four statuses are analogous to L1 transaction statuses. Note also, that there is still the possibility of an L1 reorganization that could revert the status of an L2 transaction back to success. Also at the time of writing, there is no possibility of an L2 reorganization unless through a malicious attacker. Finally, more fine-grained statuses such as "Pending L1 Finalization" could be introduced to deliver more insights to end-user and improve the user experience.
This was referenced Jul 9, 2024
Closed
@smartcontracts @DZGoldman @t0mcr8se @0x000hx @leeederek -- please, review and approve this PR ASAP. Thank you! |
Closed
Therecanbeonlyone1969
changed the title
Draft of L2 Transaction Fee API specification
L2 Transaction Fee API specification
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testability requirements will be added once all requirements have been agreed upon.