-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SRI - 811 Add workflowId and workstepId to transaction #820
Merged
biscuitdey
merged 13 commits into
develop
from
811-sri-add-workflowid-and-workstepid-to-transaction-model-and-generate-instance-ids-on-each-execution
Jul 22, 2024
Merged
SRI - 811 Add workflowId and workstepId to transaction #820
biscuitdey
merged 13 commits into
develop
from
811-sri-add-workflowid-and-workstepid-to-transaction-model-and-generate-instance-ids-on-each-execution
Jul 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… transaction model
…ransaction execution
biscuitdey
requested review from
skarred14,
ognjenkurtic,
Therecanbeonlyone1969,
Kasshern,
Ybittan and
skosito
as code owners
July 22, 2024 13:15
1 task
Therecanbeonlyone1969
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
biscuitdey
deleted the
811-sri-add-workflowid-and-workstepid-to-transaction-model-and-generate-instance-ids-on-each-execution
branch
July 22, 2024 17:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds workflowId and workstepId to transaction.
This values are generated once a transaction execution is started.
Related Issue
#811
Motivation and Context
Previously, the values being stored was the workflowId and workstepId in the workflowInstanceId and workstepInstanceId
How Has This Been Tested
All previous tests are running.
Types of changes
Checklist